st/entry: Fix clutter action leak when unsetting icon

The name of the removed action did not match the added one anymore,
effectively "leaking" an action whenever an icon was shown and hidden.
This was primarily affecting the clear button in the shell search.

Fixes: 0bf49afda ("Replace ClutterClickAction with new ClutterClickGesture")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4095>
(cherry picked from commit a77dbe3d883adb6232bd455ea3c3deb86a61ed50)

diff --git a/src/st/st-entry.c b/src/st/st-entry.c
index 963cb5a4a3e72b91a8fe7bb015a29b8c581ab2d5..83960b3b4bc1b375582d2c212dbec6bccc17f74c 100644 (file)
--- a/src/st/st-entry.c
+++ b/src/st/st-entry.c
@@ -1360,7 +1360,7 @@ _st_entry_set_icon (StEntry       *entry,
 {
   if (*icon)
     {
-      clutter_actor_remove_action_by_name (*icon, "entry-icon-action");
+      clutter_actor_remove_action_by_name (*icon, "entry-icon-click-gesture");
       clutter_actor_remove_child (CLUTTER_ACTOR (entry), *icon);
       *icon = NULL;
     }